Merge pull request #1668 from martinoss/fix-ui-sref-inside-svg

fix($StateRefDirective): resolve support for svg anchor elements #1667
angular-ui · Jan 6, 2015 · b7aae02 · b7aae02
2 parents 7e38adb + 0149a7b
commit b7aae02
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/stateDirectives.js b/src/stateDirectives.js
@@ -86,9 +86,12 @@ function $StateRefDirective($state, $timeout) {
     link: function(scope, element, attrs, uiSrefActive) {
       var ref = parseStateRef(attrs.uiSref, $state.current.name);
       var params = null, url = null, base = stateContext(element) || $state.$current;
-      var newHref = null, isAnchor = element.prop("tagName") === "A";
+      // SVGAElement does not use the href attribute, but rather the 'xlinkHref' attribute.
+      var hrefKind = toString.call(element.prop('href')) === '[object SVGAnimatedString]' ?
+                 'xlink:href' : 'href';
+      var newHref = null, isAnchor = element.prop("tagName").toUpperCase() === "A";
       var isForm = element[0].nodeName === "FORM";
-      var attr = isForm ? "action" : "href", nav = true;
+      var attr = isForm ? "action" : hrefKind, nav = true;
 
       var options = { relative: base, inherit: true };
       var optionsOverride = scope.$eval(attrs.uiSrefOpts) || {};