chore($urlRouter): add tests for location syncing

angular-ui · Mar 24, 2014 · 34207b1 · 34207b1
1 parent 3a03042
commit 34207b1
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/src/urlRouter.js b/src/urlRouter.js
@@ -287,7 +287,7 @@ function $UrlRouterProvider(   $locationProvider,   $urlMatcherFactory) {
       },
 
       push: function(urlMatcher, params, options) {
-        $location.url(urlMatcher.format(params));
+        $location.url(urlMatcher.format(params || {}));
         if (options && options.replace) $location.replace();
       },
 

diff --git a/test/urlRouterSpec.js b/test/urlRouterSpec.js
@@ -106,6 +106,46 @@ describe("UrlRouter", function () {
       expect(called).toBeTruthy();
       expect(location.path()).toBe("/b4z");
     }));
+
+    describe("location updates", function() {
+      it('can push location changes', inject(function($urlRouter, $location) {
+        spyOn($location, "url");
+        spyOn($location, "replace");
+        $urlRouter.push(new UrlMatcher("/hello/:name"), { name: "world" });
+
+        expect($location.url).toHaveBeenCalledWith("/hello/world");
+        expect($location.replace).not.toHaveBeenCalled();
+      }));
+
+      it('can push a replacement location', inject(function($urlRouter, $location) {
+        spyOn($location, "url");
+        spyOn($location, "replace");
+        $urlRouter.push(new UrlMatcher("/hello/:name"), { name: "world" }, { replace: true });
+
+        expect($location.url).toHaveBeenCalledWith("/hello/world");
+        expect($location.replace).toHaveBeenCalled();
+      }));
+
+      it('can push location changes with no parameters', inject(function($urlRouter, $location) {
+        spyOn($location, "url");
+        $urlRouter.push(new UrlMatcher("/hello/:name"));
+
+        expect($location.url).toHaveBeenCalledWith("/hello/");
+      }));
+
+      it('can read and sync a copy of location URL', inject(function($urlRouter, $location) {
+        $location.url('/old');
+
+        spyOn($location, 'url').andCallThrough();
+        $urlRouter.update(true);
+        expect($location.url).toHaveBeenCalled();
+
+        $location.url('/new');
+        $urlRouter.update();
+
+        expect($location.url()).toBe('/old');
+      }));
+    });
   });
 
 });