fix: Introduce gridDimensionChanged event #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Support Travis for 3x branch (3x branch merge)
swalters
added a commit
that referenced
this pull request
Feb 16, 2016
fix: Introduce gridDimensionChanged event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5090
The grid menu enables a scrollbar to keep it's height under the height of the grid by 30px. However, it is only calculated when created. If auto-resize is on then the grid menu height does not get updated and therefore may get cut off. This PR adds a new event gridDimensionChanged to the gridApi which the menu can watch for to update it's style on change.