Fix(grouping) change group comparison to use sortingAlgorithm #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the grouping processor to use the sortingAlgorithm for each column, instead of strict equality for determining group membership. Change implementation of aggregationFinalizerFn on grouped rows to support customTreeAggregationFinalizerFn on grouped columns. Never show counts for date columns, since they will almost always have a cellFilter applied and changing the data type to a string will break that. Fixes angular-ui#3629
AgDude
added a commit
that referenced
this pull request
Jun 1, 2015
Fix(grouping) change group comparison to use sortingAlgorithm
AgDude
added a commit
to AgDude/ui-grid
that referenced
this pull request
Jun 12, 2015
Fix a regression introduced in angular-ui#3656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the grouping processor to use the sortingAlgorithm for each column,
instead of strict equality for determining group membership.
Change implementation of aggregationFinalizerFn on grouped columns to support
customTreeAggregationFinalizerFn.
Never show counts for date columns, since they will almost always have a
cellFilter applied and changing the data type to a string will break that.
Fixes #3629