Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subgrid feature #1545

Merged
merged 1 commit into from
Sep 18, 2014
Merged

subgrid feature #1545

merged 1 commit into from
Sep 18, 2014

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 17, 2014

A couple of things to mention:

  1. Changes in core are mostly those that are done to fix scrolling to use row.height instead of gridOption.rowHeight.
  2. Row headers column currently do not have column header. This is issue with row header functionality that needs to be fixed.

@c0bra
Copy link
Contributor

c0bra commented Sep 18, 2014

A couple issues:

  1. The sort ascending icon now looks like an unanimated "loading" circle?
  2. Intermittently, in Chrome, if I expand all rows then drag the vertical scrollbar down to the middle of the grid, the expanded grids simply do not render at all. I haven't had time to dig into a possible reason, or check it in any other browsers. So far this happens maybe 50% of the time. If I scroll enough either up or down then they will start rendering again.

Beyond that, this stuff is looking really great. It's pretty snappy, sorting isn't too bad with the grids expanded, it looks good visually, etc. I'd be curious to see this with horizontal scrolling.

swalters added a commit that referenced this pull request Sep 18, 2014
@swalters swalters merged commit eccd70e into angular-ui:master Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants