-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrollTo / scrollToIfNecessary not working for new row at bottom of grid (off screen) #6507
Comments
@rdkleine if you could let me know the original issue that this change was fixing then I'd be happy to have a look at implementing a fix for this that doesn't undo the fix you made? |
I have moved on from the project where the grid was needed some time ago. Ok I'll try to explain from memory:
You can reproduce in tutorial 301 |
scrollToIfNecessary no longer works if the grid only extends a few lines below the visible section of the grid - this is causing the percentage calculation for the scrollEvent to be > 1 and a recent code change #6241 put in a check so that if the percentage > 1 then the scrollEvent is not setup. I'm not sure what this change was fixing but it has broken this scenario. If I knew the reason for the original change I would fork and try to fix it but I don't want to mess with it and then break something else that was fixed originally.
Here is a plunker to replicate the issue:
http://plnkr.co/edit/F3aMCzRQmBwSDip2cZ2Z?p=preview
The text was updated successfully, but these errors were encountered: