Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showTreeRowHeader does not work for empty data #5430

Closed
dhairya-avantsoft opened this issue May 24, 2016 · 3 comments · Fixed by #6694
Closed

showTreeRowHeader does not work for empty data #5430

dhairya-avantsoft opened this issue May 24, 2016 · 3 comments · Fixed by #6694
Assignees
@mportuga
Labels
good first issue

Comments

@dhairya-avantsoft
Copy link

http://plnkr.co/edit/I6Fwu0xKEBEVJqkyUk6y?p=preview

I've just copied the plunkr for sample treegrid and update 2 lines:
showTreeRowHeader: false
and
$scope.gridOptions.data = [];

Note that showTreeRowHeader is false and still row header for tree nodes is still visible
@bjaraujo
Copy link
Contributor

I guess you have to remove ui-grid-tree-view.
But I agree it should work with settingshowTreeRowHeader: false so maybe it is a bug.

@r0ss0neri
Copy link

r0ss0neri commented Feb 27, 2018 •
edited
Loading

Still reproducible, is this a bug?

@mportuga
Copy link
Member

yes, definitely a bug.

@mportuga mportuga self-assigned this Apr 21, 2018
mportuga pushed a commit that referenced this issue Apr 24, 2018
fix(tree-base.js): Call updateRowHeaderWidth even when no data exists.
5a3527a 
Ensure row header visiblity is respected when no data is present.

fix #5430
@mportuga mportuga mentioned this issue Apr 24, 2018
Merged
mportuga pushed a commit that referenced this issue Apr 24, 2018
@mportuga
fix(tree-base.js): Call updateRowHeaderWidth even when no data exists.
49678eb 
Ensure row header visiblity is respected when no data is present.

fix #5430
m4m4m4 pushed a commit to m4m4m4/ui-grid that referenced this issue Apr 24, 2018
@m4m4m4
fix(tree-base.js): Call updateRowHeaderWidth even when no data exists.
471dddf 
Ensure row header visiblity is respected when no data is present.

fix angular-ui#5430
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
fix(tree-base.js): Call updateRowHeaderWidth even when no data exists.
563d893 
Ensure row header visiblity is respected when no data is present.

fix angular-ui#5430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mportuga mportuga

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tree-base.js): Call updateRowHeaderWidth even when no data exists. angular-ui/ui-grid
4 participants
@bjaraujo @dhairya-avantsoft @mportuga @r0ss0neri