Skip to content

Commit

Permalink
fix(core): support custom interpolation symbols on defaultColumnBuilder
Browse files Browse the repository at this point in the history
Also, fix minor linting issue on test files.

Closes #6963
  • Loading branch information
marcelo-portugal authored and mportuga committed Jan 23, 2023
1 parent 3697200 commit 7630fd3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions packages/core/src/js/services/gridClassFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,13 @@
}

if ( filterType ) {
col[templateType] = template.replace(uiGridConstants.CUSTOM_FILTERS, function() {
template = template.replace(uiGridConstants.CUSTOM_FILTERS, function() {
return col[filterType] ? "|" + col[filterType] : "";
});
} else {
col[templateType] = template;
}
return gridUtil.postProcessTemplate(template).then(function(template) {
col[templateType] = template;
});
},
function () {
throw new Error("Couldn't fetch/use colDef." + templateType + " '" + colDef[templateType] + "'");
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/i18n/i18nService.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ describe('i18nService', function () {
beforeEach(function() {
$log = jasmine.createSpyObj('$log', ['warn']);
module('ui.grid', function($provide) {
$provide.value('$log', $log)
$provide.value('$log', $log);
});
inject(function (_i18nConstants_, _i18nService_) {
i18nConstants = _i18nConstants_;
Expand Down

0 comments on commit 7630fd3

Please sign in to comment.