fix(datepicker): compatibility with angular 1.1.5 and no jquery

[Swiip]

Fix for #760

As I'm pretty noob on good GitHub contrib, don't hesitate to make comments.

There was no easy way to make unit tests in the bug conditions (no jquery and angular 1.1) so I simply verified that it doesn't breaks existings ones.

For the initial $document.unbind which failed, I didn't found better than using a boolean preventing unbind before first bind.

For the open attribute problem, as I understand this new directive : ngOpen, the open attribute is reserved in HTML5 and can only be a boolean. I therefore proposed to switch to is-open with a backward compatibilty trick allowing to use open attribute if the angular version allow it (and is-open is not used).

Hope this helps.
Matthieu

[bekos]

@Swiip Very nice. I don't think atm we care about backward compatibility, since librabry is on 0.x version. So I suggest to simplify code and readability and just rename the attribute. Just make sure you also change the tests, and write about your breaking change in the commit message. An example can be found here: f45815c

For the binding I like your soultion and I agree that it is not testable with the current setup. Doesn't the same problem happens and with the elementFocusBind ?

[Swiip]

For the breaking change, I'll modify the test, thanks for the commit example.

For elementFocusBind, it just doesn't produce the same problem. It should be a difference to find inside jqLite.

[bekos]

For elementFocusBind, it just doesn't produce the same problem. It should be a difference to find inside jqLite

@Swiip If attribute is initially open it tries to unbind the elementFocusBind which is not already binded. You should probably address this case in the same way .

[Swiip]

No problem, I was not sure. It's done.

[pkozlowski-opensource]

@bekos Is this one good to be merged?

[bekos]

LGTM

[pkozlowski-opensource]

Landed as bf30898. Thnx @Swiip !