This repository has been archived by the owner on May 29, 2019. It is now read-only.
docs(tabs): get rid of 'active' option on uib-tab directive #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rective since it's no longer valid there
|
Can you give a bit of a description about why you are making this change for people who are going to review it? |
|
@deeg Description has been added |
|
I believe this is already fixed in master? |
|
Ah, no. Different template. |
|
@deeg, this is fine to merge. |
icfantv
added
needs: merging
type: demo site
and removed
needs: review
type: doc
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "active" option no longer exists for the uib-tab directive. It has been moved to uib-tabset. Looks like this little piece of documentation didn't get updated to remove it whenever this change was made.