Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(modal): missing require in modal #5786

Closed
wants to merge 1 commit into from
Closed

fix(modal): missing require in modal #5786

wants to merge 1 commit into from

Conversation

mhchen
Copy link
Contributor

@mhchen mhchen commented Apr 12, 2016

Attempting to import the modal alone without position causes the error:

Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.module.modal due to:
Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.modal due to:
Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.position due to:
Error: [$injector:nomod] Module 'ui.bootstrap.position' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

Apologies, I'm not sure how to update tests or provide a demo for this since it's strictly a webpack build issue.

Commit message:
Fixes the fact that ui.bootstrap.position is an angular module
dependency but not required in src/modal/index.js

Fixes the fact that ui.bootstrap.position is an angular module
dependency but not required in modal
@wesleycho
Copy link
Contributor

This LGTM

@wesleycho wesleycho added this to the 1.3.2 milestone Apr 12, 2016
@wesleycho wesleycho closed this in a887d2b Apr 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants