This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepickerPopup): do not show incorrect warning #5747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeg
force-pushed
the
fix-datepicker-popup
branch
from
a018626 to
fa2a7df
Compare
deeg
added a commit
to deeg/bootstrap
that referenced
this pull request
Apr 5, 2016
This stops the datepicker popup from incorrectly showing a warning when not supplying any datepicker options. Closes angular-ui#5747
This stops the datepicker popup from incorrectly showing a warning when not supplying any datepicker options. Fixes: angular-ui#5743 Closes angular-ui#5747
deeg
force-pushed
the
fix-datepicker-popup
branch
from
fa2a7df to
9800208
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the datepicker popup from incorrectly showing a warning when not supplying any datepicker options.
Plunker demonstrating issue
Use the first datepicker and see the warning message in the console.
Plunker demonstrating fix
Notice warning message is no longer there.