This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(typeahead): Add title to matches #5252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <a href | ||
| tabindex="-1" | ||
| ng-bind-html="match.label | uibTypeaheadHighlight:query" | ||
| ng-attr-title="{{match.label}}"></a> |
There was a problem hiding this comment.
Any reason for ng-attr here instead of just title="{{...}}"?
There was a problem hiding this comment.
These guys explain it pretty well.
It is basically so you never see the text {{match.label}} in the tooltip. This will only add the title attribute with the actual value of match.label.
|
LGTM, thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a title attribute to the typeahead matches.
This helps if users want to truncate text and set a max width of the typeahead.
This allows the user to hover over a match and get the full text of the label.
Let me know if you want me to make this configurable in the options to allow the user to chose if they want the title attribute.