This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): ng-model-options: allowInvalid support #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -605,6 +611,9 @@ function(scope, element, attrs, $compile, $parse, $document, $rootScope, $positi | |||
| datepickerEl = angular.element(popupEl.children()[0]); | |||
| datepickerEl.attr('template-url', datepickerTemplateUrl); | |||
|
|
|||
| scope.ngModelOptions = { $options: angular.extend({ allowInvalid: false }, ngModelOptions) }; | |||
There was a problem hiding this comment.
Is there any particular reason that this should be exposed on scope?
There was a problem hiding this comment.
I don't think it's necessary, I copied some of the code from @davious (forgot to mention that originally in the pull request) and he had it in there.
|
I see, thanks, ngModel.$options is definitely much simpler. Does this look right? |
|
Oops...I messed up with my commit - this is now in as 2460e42 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues - #4694, #4837
Somewhat based on davious@cba7a61 from @davious