Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(dropdown): restore deprecated directives #4514

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Adds uib- prefix to dropdownConfig
  • Restores functionality to deprecated directives

Supercedes #4512.

- Adds uib- prefix to `dropdownConfig`
- Restores functionality to deprecated directives
@wesleycho wesleycho force-pushed the fix/dropdown-rename branch from 0ab0dd5 to fae387b Compare October 3, 2015 07:39
@Foxandxss
Copy link
Contributor

Here you are also moving controllers to the deprecated zones. In the others prefixes, we simply prefix controllers and we tell the deprecated directives to use it. That works too.

I like your way of doing that as well, but I think we shouldn't have two ways to deprecate and pick one. We can do it this way and update the others or modify this to be like the others.

@wesleycho
Copy link
Contributor Author

I've been doing this in general - I do it just in case we have some users using the controllers directly & building custom directives around them.

@Foxandxss
Copy link
Contributor

That means that the other ones should have the same thing.

@wesleycho
Copy link
Contributor Author

Merging this in for now, will investigate the others today.

@wesleycho wesleycho closed this in e7c5879 Oct 3, 2015
@wesleycho wesleycho deleted the fix/dropdown-rename branch November 7, 2015 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants