feat(collapse): use uib- prefix #4370
Conversation
|
@wesleycho I need you to check this out, I know you're in vacation, but if you agree, I can do a couple of this before you come back. @icfantv you too. |
|
LGTM Controllers need to be prefixed too for the others - this should be a 100% breaking change I think. Thoughts? |
|
You're right @wesleycho, we should prefix controllers too. Will update the instructions. This PR is not a breaking change tho, it still works as it did before. The breaking change will come when we decide to We need somehow (for when we release 0.14 with all prefixes) to announce that we have prefixes now and that the users should update their projects ASAP. |
|
Right, my comment was just before you delved down into the other work :) . As for the notifying users, perhaps we can mention it on the home page and the README - the deprecation notices will serve enough warning to current users I think. |
Foxandxss
force-pushed
the
collapseprefix
branch
from
f0d72e7 to
bf3f29e
Compare
|
@wesleycho Updated. Now we just need to remove from the comment to the bottom to clean the deprecated modules. |
|
Alright, this looks better to me - good to go! |
So this is the proposal for collapse prefixing.