This repository has been archived by the owner on May 29, 2019. It is now read-only.
Optional autofocus on typeahead selection #2270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added an optional parameter for autofocus on selection
Fix for jshint
|
Sorry for that, now it passed. Do you think autofocus should be enabled by default? This way it won't affect previous users but others can disable it. |
angi-
changed the title
|
Now the optional parameter disables the autofocus leaving the old functionality intact. This also adresses the issue #1903 |
|
Can you squash your commits and rebase off of current master? Scheduling this for 0.13.1, this just needs documentation updates. |
|
I have done this on another pull request, I also created automated tests: #3211 Let me know if I can further help to get this update in the next release. |
|
@angi- So should we close this PR? |
|
This just needs documentation updates and it should be good to go. |
|
Closing, as it has been superceded by #4212. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues when you want an input to clear value on focus and after selection it gets cleared again because of the autofocus. I added an optional parameter for autofocus on selection, it is disabled by default.