This repository has been archived by the owner on May 29, 2019. It is now read-only.
FIX - DatePicker now accepts input value fields with the right formatDate #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that when you type the date in a input field instead of picking it. It was not parsing it right through the dateFormat informed, so I fix it. This Fix will parse the input value typed also using the dateFormat.
| @@ -372,13 +372,20 @@ function ($compile, $parse, $document, $position, dateFilter, datepickerPopupCon | |||
| ngModel.$setValidity('date', true); | |||
| return viewValue; | |||
| } else if (angular.isString(viewValue)) { | |||
| var date = new Date(viewValue); | |||
| if (isNaN(date)) { | |||
| var dateStr = dateFilter(viewValue, dateFormat); | |||
There was a problem hiding this comment.
Here it uses the dateFilter service to format the "Date typed (string)" in the format the user is expecting.
Fixing comparison to use === instead or == if (dateStr === undefined)
Another fix, so the dates can be typed in the format: February, 24 2014 and not 99/99/9999 anymore
Just some fix to pass jshint check and a little optimization. Now it already parse the string and then if it is in the formar 99.99.9999 parses again.
Trying to fix JSHint Errors
|
@getuliojr Thx for your time on this one, but your PR handles a specific use case, so it cannot be merged, as we are looking for a more general solution to this problem. Additionally, almost all PRs must have an accompanying test case. |
|
Eight months later, this bug is already here ... bekos, why are you closed this issue ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when you type the date in a input field instead of picking it. It was not parsing it right through the dateFormat informed, saw this problem on some issues: (#956, #1107, #1430).
This Fix will parse the input value typed with the dateFormat informed and pick it on the datepicker if the date is valid. Hope it can help others. Working fine for me now when dateFormat is 'dd/MM/YYYY'. I can type date in this format and it will pick it right in the datepicker.