Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

datepicker-popup remains on screen when launched from modal that goes away #5058

Closed
bhelzer opened this issue Dec 11, 2015 · 4 comments
Closed

Comments

@bhelzer
Copy link
Contributor

bhelzer commented Dec 11, 2015

Open a datepicker-popup from a modal, with datepicker-append-to-body set to true. Click outside the modal to close it. The datepicker stays around even though its scope was destroyed.

See http://plnkr.co/edit/YdWmqYPFBNbv4vhQZc4t?p=preview

@wesleycho
Copy link
Contributor

This looks like a bug to me, but need further investigation. What appears to be happening is that the popup is binding to an incorrect template when appendToBody is used, causing a comment tag to be removed instead of the right element.

@wesleycho wesleycho added this to the 1.0.0 milestone Dec 11, 2015
@wesleycho wesleycho modified the milestones: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4 Jan 8, 2016
@deeg
Copy link
Contributor

deeg commented Jan 15, 2016

I am also having this issue, it does seem to be a bug.

Destroying the scope keeps the datepicker visible on the screen. The modal does not have anything to do with it, the issue happens with any $destroy event.

@wesleycho
Copy link
Contributor

Yeah, the incorrect DOM node is being used to remove - this is a bug in our tracking of the popup DOM element.

@deeg
Copy link
Contributor

deeg commented Jan 15, 2016

Sounds good, will try to get out a PR for this in the next few days.

deeg added a commit to deeg/bootstrap that referenced this issue Jan 15, 2016
deeg added a commit to deeg/bootstrap that referenced this issue Jan 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants