-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Allow different accordion-group classes #3968
Comments
This sounds reasonable - feel free to open a PR. |
One question. The behavior of this feature is:
|
Another solution is |
And when I place |
it could be |
ok, thx |
Just a suggestion, rather than go through all the work involved with removing/adding classes, would it be better to offer the ability to override the templates with an attribute? I.E., changing this:
To this:
|
That is also a valid option/feature - may be even better for performance reasons & simplified api. |
It got me thinking, it would be a nice (and easy) feature to add to all the simple (mostly markup) directives and would relieve the burden of having to do customization on the default templates. |
I think that give option to change the default template is good, in other way, when you change the template "only to customize the css" you lose features like accessibility (that isn't implemented in accordion yet). |
Hm? I merged your PR with accessibility enhancements to collapse in 9255134 . |
@wesleycho sorry, I talked collapse, but is accordion. |
Just an update here. We now have support for @RobJacobs solution in If we allow customization here, don't we also need to also add it for the It sounds like using the custom template solution is the right way to go here and I think we can close this. |
In this case, there are other supported panel classes, such as |
Ah crud, I'd forgotten about those. So we probably only want to support replacing just the |
* add support for custom panel class fixes angular-ui#3968
* add support for custom panel class fixes angular-ui#3968
The class of panels (aka accordion groups) at https://github.com/angular-ui/bootstrap/blob/master/template/accordion/accordion-group.html are hard-coded to
panel-default
. I would like to be able to use a different one. Currently, even if I useng-class
to assign another class to the panel, thepanel-default
class is still there.The text was updated successfully, but these errors were encountered: