Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Allow custom triggers on tooltips/popovers #382

Closed
thatmarvin opened this issue May 1, 2013 · 1 comment
Closed

Allow custom triggers on tooltips/popovers #382

thatmarvin opened this issue May 1, 2013 · 1 comment

Comments

@thatmarvin
Copy link

My use case is detailed here.

I had to fork tooltip.js to add a custom entry to triggerMap. It'll be super nice to be able to specify random show/hide mappings (popover-trigger-show and popover-trigger-hide maybe?)

Thoughts, @joshdmiller?
@joshdmiller
Copy link
Contributor

I don't really see this as a common use case, but it would be pretty trivial to add a method to the provider to allow extending/overriding the default trigger mappings. I might throw something together in the next few days (when we get through with PR #369) as I want to expose more of the provider API and add its documentation. I have intentionally left it undocumented for now as it was in a little bit of a flux, but I think we're largely past that.

As for the attribute -trigger-hide, this is a little trickier to implement because $observe orders are a little unpredictable and we need both values to know which one to pick. But adding to the map should be just fine.

joshdmiller pushed a commit to joshdmiller/bootstrap that referenced this issue Jun 23, 2013
feat(tooltip): Added custom trigger support
37f4c22 
The $tooltipProvider now allows extending the default set of open and
close trigger mappings.

Closes angular-ui#382.
@joshdmiller joshdmiller mentioned this issue Jun 23, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tooltip): Added custom trigger support joshdmiller/bootstrap
2 participants
@joshdmiller @thatmarvin