This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(typeahead): adding/removing class when source is promise #321
Comments
@skytracer thnx for your input and inspiration but I don't think we should be adding classes like this. Doing so would mean that we are doing DOM manipulation on every keystroke and also we would be hard-coding a CSS class. But the use-case you've got is very valid so I would propose to solve it slightly differently. The typeahead directive could expose the <input ng-model="mymodel" typeahead="..." typeahead-loading="isLoading" ng-class="{myLoadingStyle: isLoading}"> WDYT? |
@skytracer I've implemented an alternative, model-oriented approach in b58c9c8, as described above. Let me know what do you think. |
@pkozlowski-opensource I think your approach opens more use-cases and I am happy with it |
codedogfish
pushed a commit
to codedogfish/angular-ui-bootstrap
that referenced
this issue
Sep 15, 2015
angular-ui#319 fix for lock selections
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I think it would be nice to set a class to mark the beginning and the end of the async source pull
I am using this to show a spinner at the right end of the input.
This is my code
The text was updated successfully, but these errors were encountered: