Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

'string' type resolves in $modals are not supported #2676

Closed
simoneb opened this issue Sep 9, 2014 · 0 comments
Closed

'string' type resolves in $modals are not supported #2676

simoneb opened this issue Sep 9, 2014 · 0 comments
Labels
component: modal type: enhancement
Milestone
0.13.3 (Fixes)

Comments

@simoneb
Copy link

simoneb commented Sep 9, 2014

As per https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L322 it seems that 'string' type resolves are not handled properly in $modal.
wesleycho added a commit to wesleycho/bootstrap that referenced this issue Aug 6, 2015
@wesleycho
feat(modal): allow users to resolve with strings
30aa6e5 
- Allows users to specify a string reference to a service for injection

Closes angular-ui#2676
@wesleycho wesleycho added this to the 0.13.3 (Fixes) milestone Aug 6, 2015
@wesleycho wesleycho mentioned this issue Aug 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: modal type: enhancement
Projects
None yet
Milestone
0.13.3 (Fixes)
Development

No branches or pull requests
3 participants
@simoneb @chrisirhc @wesleycho