Datepicker displays wrong week numbers

[guenter-wolf]

The datepicker displays wrong week numbers if the starting-day is 0 (Sunday).
Please compare the week numbers of angularjs-ui bootstrap Inline Datepicker at:
http://angular-ui.github.io/bootstrap/
with the ISO 8601 conform week numbers at:
http://www.epochconverter.com/date-and-time/weeknumbers-by-year.php

The angularjs-ui datepicker displays e.g. for Tue Aug 19 2014 the week number 33,
but the ISO 8601 conform week number is 34.

The problem seems to be that the datepicker uses the first day of the row in the calendar grid to determine the week number of the corresponding row.
This leads to wrong results if the first day of the row is Sunday (which is the datepicker default starting-day).
According to ISO 8601 the week starts on Monday and ends on Sunday.
Consequently the datapicker will display for the week Sun Aug 17 - Sat Aug 23 the number of the week that ended on Sun Aug 17 and not the week that starts on Mon Aug 18.
However, please note that the Popup Datepicker at
http://angular-ui.github.io/bootstrap/ displays the correct week number, since the startingDay is 1 (Monday).

Suggested Solution:
Use the day in the middle of the row to determine the week number of the corresponding row, i.e. replace in datepicker.js the line:
var weekNumber = getISO8601WeekNumber( scope.rows[0][0].date )
with:
var weekNumber = getISO8601WeekNumber( scope.rows[0][3].date )
This will display the correct week number regardless of whether the week display starts with a Sunday or a Monday.

[guenter-wolf]

I have created a pull request for this bug fix:
#2517

[stephent]

Not sure if this is a related issue, but December 2015 shows weeks 49 through 54, January 2016 shows weeks 53 through 58 in the popup.

Observed in 0.11.0

[guenter-wolf]

This is another bug:
It calculates the ISO 8601 Week Number only for the first row of a month and for the following rows of the month it just increments the week number.
This generally works, but it may create wrong week numbers for December and January.
The correct week numbers for December 2015 calendar display should be:
49,50,51,52,53,1
and for the January 2016 calendar:
53,1,2,3,4,5
I have changed the pull request #2517 to fix also this bug.

[guenter-wolf]

@pkozlowski-opensource @chrisirhc
Why is this simple bug fix still not merged?
Sorry, this is my first attempt to contribute. Is there anything wrong with my pull request?
Shouldn't bugs like this have highest priority?
I have noticed that memory leak issues with the datepicker seem to get a lot more attention.
But who cares about memory leaks? If the datepicker displays wrong information, it is useless.

[mforkin]

+1 Need this fix

[DannyDouglass]

+1 on this item - any chance we get that pull request accepted if it fixes these issues?

[wilgert]

+1 need this very badly

[Burgov]

+1 much needed here as well!

[LooMan]

+1 Need this fix! :)

[mhaamann]

+1 - It's a bug fix, why not merge it?

[chrisirhc]

I've reviewed the PR and it needs some work before we can get it merged in.

[stephanmullerNL]

Since I had no idea of knowing when the adjustments would be made here I made a new PR that covers the issues that were still relevant: #3158. Starting day seemed to have already been fixed in the meantime.

[yuyokk]

Hey guys,

Do you have any updates on this bug? When do you plan to fix it?
Thank you!

[karianna]

https://github.com/angular-ui/bootstrap#impt---2015-plans-and-angular-13-support

[stephanmullerNL]

@yuyokk I still have a PR outstanding for this, but as you can read in the comments I'm confused by the conflict in specs (must adhere to ISO standards vs must allow sunday as the week's first day). I don't know how to solve that, it seems more like a business decision to me than something code can easily fix.

#3158

[yuyokk]

@picodealion I see what you mean. I appreciate your answer. Thanks.

[LiamK]

Is there any way to get rid of that last week? For example, in the last image above, the last row on the January 2016 calendar is not even January, it's February.

[jkevlorayna]

Replace this one

with this code

on ui-bootstrap-tpls.js

Think this one will solve your problem!

[chinchan]

wow. Thanks for this fix. I just make your code into more elegant looks. I just removed the index since it does not needed. Thanks.

[jkevlorayna]

@chinchan awesome !