onReady usage

[marcelorio]

The rootscope solution works, but the onReady solution presents as being ready, but doesn't work. Am I using it correctly?

I am using angular-translate 2.8.1 and angular 1.4.6

$translatePartialLoader.addPart('pages/cadastros/unidade-metrica');

           $rootScope.$on('$translateChangeSuccess', function () {
                $scope.label.yes = $translate.instant('Cost_UnitOfMeasure_Yes');
            });

            $translate.onReady().then(function () {
                if ($translate.isReady()) {
                    $scope.label.no = $translate.instant('Cost_UnitOfMeasure_No');

                }
                console.log($translate.isReady()); // returns true but translation isn't loaded
            });

[knalli]

@marcelorio Do you using 2.8.1? Because the bug with isReady() should be fixed.

$translate.onReady() is already a promise which does not require to check for isReady().

[knalli]

Ah, I have missed your said already using 2.8.1.

So, no you don't have to call isReady(), although it should work and looks like the bug was not fixed in 2.8.1

[marcelorio]

Thank you for the fast reply knalli.

Indeed the isReady() inside the onReady() is a bit redundant. I only used it as a test to see if it would show up in the console, and it does, but the translation isn't loaded.

[matikun86]

I don't know if it's the same cause but I was using $translateProvider.preferredLanguage and I think that was firing the onReady callbacks. I removed that line and onReady fired correctly (at least the first time)

[knalli]

What do you mean?

[marcelorio]

I was using $translateProvider.preferredLanguage, but taking it from the code did not solve the problem..

[knalli]

So basically this does not work for you? https://github.com/angular-translate/angular-translate/blob/2.8.1/src/directive/translate-cloak.js#L37-L39

[knalli]

In combination with a condition I 've fixed a bug. I'll close this in favor.