fix: throws an error if app building fails #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, I will soon review this! 👍 |
JohannesHoppe
pushed a commit
to angular-schule/ngx-deploy-starter
that referenced
this pull request
Dec 20, 2019
cherry-pick from e7f6a51 of angular-cli-ghpages/master by @masaxsuzu see angular-schule/angular-cli-ghpages#85
|
Thank you the review. |
|
Many thanks for your support, I'm right now preparing a bigger release. |
dianjuar
pushed a commit
to bikecoders/ngx-deploy-npm
that referenced
this pull request
Feb 27, 2021
cherry-pick from e7f6a51 of angular-cli-ghpages/master by @masaxsuzu see angular-schule/angular-cli-ghpages#85
12 tasks
xellafe
pushed a commit
to xellafe/ngx-deploy-git-repo
that referenced
this pull request
Oct 2, 2024
cherry-pick from e7f6a51392dd97973c98b5420c4903d2bc1e2721 of angular-cli-ghpages/master by @masaxsuzu see angular-schule/angular-cli-ghpages#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am generating this pull request w.r.t this Issue #74.
I think that this issue is caused by actions.ts#L33. The result has
successanderrorproperties, but they seem to be ignored in the line.I have added two changes in this PR.