fix: save package in devDependencies #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815
|
LGTM |
|
Thank you very much for pointing this out. I will add this to |
He already raised a PR :) |
JohannesHoppe
pushed a commit
to angular-schule/ngx-deploy-starter
that referenced
this pull request
Nov 6, 2019
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815 (cherry picked from commit 3dfd8d6) closes #12 see angular-schule/angular-cli-ghpages#81
xellafe
pushed a commit
to xellafe/ngx-deploy-git-repo
that referenced
this pull request
Oct 2, 2024
In the latest versions of the CLI `ng-add` packages can be added to `devDependencies` and this package is perfect for such use case since it's only needed for development. See: angular/angular-cli#15815 (cherry picked from commit 3dfd8d64a6781a4081816a2022a66283c2b7247b) closes #12 see angular-schule/angular-cli-ghpages#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest versions of the CLI
ng-addpackages can be added todevDependenciesand this package is perfect for such use case since it's only needed for development.See: angular/angular-cli#15815