Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#185 Fixing critical vulnerabilities on 2.0.0-beta.2, caused by [email protected] #186

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

isahann
Copy link

@isahann isahann commented May 7, 2024

Just upgraded to the latest version of gh-pages available at the moment.
After upgrading, removed the node_modules, package-lock.json, and then ran a fresh npm i.
Building with npm build runs just fine. And after fixing a single test, npm test (building first) passes all tests too.

Please feel free to request any changes.

@isahann isahann changed the title Fixing critical vulnerabilities on 2.0.0-beta.2, caused by [email protected] #185 Fixing critical vulnerabilities on 2.0.0-beta.2, caused by [email protected] May 7, 2024
@fmalcher
Copy link
Member

fmalcher commented May 8, 2024

Thank you so much, Isahann! @JohannesHoppe will review and merge this one.

src/engine/engine.spec.ts Outdated Show resolved Hide resolved
@JohannesHoppe
Copy link
Member

JohannesHoppe commented May 8, 2024

@isahann Thanks for starting this PR! 😃 🙏 Do you think you have the resources to figure out how we can address the breaking change?

@isahann
Copy link
Author

isahann commented May 8, 2024

@isahann Thanks for starting this PR! 😃 🙏 Do you think you have the resources to figure out how we can address the breaking change?

I've just downloaded the repo, haven't checked much of it besides the package.json and the breaking test.... But I'll try to take a better look into it...

@isahann isahann requested a review from JohannesHoppe May 8, 2024 14:10
@JohannesHoppe
Copy link
Member

We have holidays in Germany. I will run all tests on Monday! 👍

@musicEnfanthen
Copy link

@JohannesHoppe Any updates from the Monday tests? Would be awesome to see this critical vulnerability fixed.

@davayd
Copy link

davayd commented Jun 23, 2024

Excuse me, just commented to up the topic

@kayvanbree
Copy link

Any updates on this?

@mpellerin42
Copy link

I'm also looking forward this new version to be available, any update on this PR?

@namdhevTW
Copy link

Looking forward to merge this PR - folks. Current version is causing havoc with the critical vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants