-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#185 Fixing critical vulnerabilities on 2.0.0-beta.2, caused by [email protected] #186
base: main
Are you sure you want to change the base?
Conversation
Thank you so much, Isahann! @JohannesHoppe will review and merge this one. |
@isahann Thanks for starting this PR! 😃 🙏 Do you think you have the resources to figure out how we can address the breaking change? |
I've just downloaded the repo, haven't checked much of it besides the package.json and the breaking test.... But I'll try to take a better look into it... |
We have holidays in Germany. I will run all tests on Monday! 👍 |
@JohannesHoppe Any updates from the Monday tests? Would be awesome to see this critical vulnerability fixed. |
Excuse me, just commented to up the topic |
Any updates on this? |
I'm also looking forward this new version to be available, any update on this PR? |
Looking forward to merge this PR - folks. Current version is causing havoc with the critical vulnerabilities |
Just upgraded to the latest version of
gh-pages
available at the moment.After upgrading, removed the
node_modules
,package-lock.json
, and then ran a freshnpm i
.Building with
npm build
runs just fine. And after fixing a single test,npm test
(building first) passes all tests too.Please feel free to request any changes.