Memory leak fix in decorator implementation. #410
Conversation
- Fixes memory-leaks in NgRedux select decoratos that instantiate and return new observable everytime getter is called
|
Just fyi, this change broke tests in my application. I was subscribing to a @select decorator of a component inside the tests, firing actions and testing if the state changes correctly via selector. As a good citizen I reset the store and everything else before every test. This setup now breaks as the observable (var result) is cached at "compile time" (I know there is not real compile time in JS) hard binding to the initial store ignoring the swapping out of the store in my tests. I worked around this by using store.select() instead of the decorator. This should imho have been a breaking change, not a patch level one. |
|
see issue #413 |
|
Didn't see that one, sorry. Thanks for the hint! |
|
No worries - it wasn't supposed to be a breaking change 😳 I've released 6.4.2 which fixes the regression. |
Fix for angular-redux/example-app#34, thanks to @aminpaks for the fix. Reconstituted from #409, with an additional commit from me to remove unintentionally-committed build output.