Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: form controller is not working properly (validators should 1 single time set) #163

Closed
AnthonyNahas opened this issue Apr 18, 2019 · 1 comment
Closed

bug: form controller is not working properly (validators should 1 single time set) #163

AnthonyNahas opened this issue Apr 18, 2019 · 1 comment
Assignees
@AnthonyNahas
Labels
bug Something isn't working ready

Comments

@AnthonyNahas
Copy link
Member

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Versions

latest

Repro steps

get reference of the mat-password-strength component and get access to the formController --> the validators are not set properly

Desired functionality

ability to use the validators in combination with mat-error : e.g:

<!--password error msgs-->
              <mat-error *ngIf="passwordComponentWithValidation.passwordFormControl.invalid">
                Password is invalid
              </mat-error>
              <mat-error *ngIf="passwordComponentWithValidation.passwordFormControl.hasError('required')">
                Password is required
              </mat-error>
              <mat-error *ngIf="passwordComponentWithValidation.passwordFormControl.hasError('pattern')">
                Password is not valid
              </mat-error>
@AnthonyNahas AnthonyNahas self-assigned this Apr 18, 2019
@AnthonyNahas AnthonyNahas added the bug Something isn't working label Apr 18, 2019
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): exported colors and criteria enum #163 #143
92d76c7
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): exported a reg exp class to use it across the library #163
91d5f85 
 # 143
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): adjusted the exports in the main module #163
11c22d8
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): set min and max length validator for the form controller …
6165988 
…#163 #143
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): improved form controllers validators #143 #163
d6ae437
AnthonyNahas added a commit that referenced this issue Apr 18, 2019
@AnthonyNahas
fix(package): improved validate function in the validator class #143 #…
0191024 
…163
AnthonyNahas added a commit that referenced this issue Apr 19, 2019
@AnthonyNahas
fix(package): improved the confirmation password form controller #163 #…
6ec1d1f 
…143
AnthonyNahas added a commit that referenced this issue Apr 24, 2019
@AnthonyNahas
fix(package): update the validators on changed password value #163 #143
c27acdb
AnthonyNahas added a commit that referenced this issue Apr 24, 2019
@AnthonyNahas
fix(demo): adjusted the docs of the lib examples in md #163 #143
8daf84e
AnthonyNahas added a commit that referenced this issue Apr 24, 2019
@AnthonyNahas
fix(demo): adjusted the docs of the lib examples in md #163 #143
e2dd41a
AnthonyNahas added a commit that referenced this issue Apr 26, 2019
@AnthonyNahas
docs(project): updated the readme #163 #143
261119c
@AnthonyNahas
Copy link
Member Author

fixed in v3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyNahas AnthonyNahas

Labels
bug Something isn't working ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnthonyNahas