Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use angular ~1.2 before migrated to 1.3 #655

Merged
merged 1 commit into from
Nov 3, 2014

Conversation

sigriston
Copy link
Contributor

Change angular version spec from ">=1.2.*" to "~1.2" to ensure generator
tests run before migration to 1.3 is completed.

Closes #654

@JaKXz
Copy link
Collaborator

JaKXz commented Oct 22, 2014

👍

Change angular version spec from ">=1.2.*" to "~1.2" to ensure generator
tests run before migration to 1.3 is completed.

Closes angular-fullstack#654.
@sigriston
Copy link
Contributor Author

I just rebased the commit because I had goofed the concats in the test, which caused only dependencies to be checked, and devDependencies to be skipped. :-(

@kingcody
Copy link
Member

LGTM, had the same problem earlier this week; adjusting the deps as you have was my solution as well.

DaftMonk added a commit that referenced this pull request Nov 3, 2014
fix(deps): use angular ~1.2 before migrated to 1.3
@DaftMonk DaftMonk merged commit b986998 into angular-fullstack:canary Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants