Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "disables the caching functionality of imagemin transitionally un... #188

Closed

Conversation

delight
Copy link
Contributor

@delight delight commented Apr 16, 2014

...til the problem with the current version of grunt-contrib-imagemin (0.5.0) is sorted out"

This reverts commit 3e435fa.

The problem doesn't seem to occur any longer.

I guess some newer grunt deps fixed it ... would like to now what change fixed it - as the dependency is still on grunt-contrib-imagemin (0.5.0)

… until the problem with the current version of grunt-contrib-imagemin (0.5.0) is sorted out"

This reverts commit 3e435fa.

The problem doesn't seem to occur any longer.
@JaKXz
Copy link
Collaborator

JaKXz commented May 31, 2014

The problem doesn't seem to occur any longer.

@delight, I'm sorry, I'm a little confused by your description. Is this still an issue?

@delight
Copy link
Contributor Author

delight commented Jun 1, 2014

@JaKXz it would be good if you could confirm that the problem is gone. For me it was.

thnx

@JaKXz
Copy link
Collaborator

JaKXz commented Jun 2, 2014

@delight sorry I should've clarified: I'm confused as to what the problem actually is [or was]?

@delight
Copy link
Contributor Author

delight commented Jun 2, 2014

@JaKXz there was a problem with imagemin #123 and a temporary fix was introduced #124 by disabling the caching.

This PR reverts this temporary fix!

Hope this clarifies your confusion.
Would still appreciate a confirmation if you are able to. Thnx :)

@JaKXz
Copy link
Collaborator

JaKXz commented Jul 16, 2014

Closing with 2.0

@JaKXz JaKXz closed this Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants