Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): Add all style files to inject:css #1747

Closed
wants to merge 1 commit into from
Closed

fix(css): Add all style files to inject:css #1747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/templates/gulpfile.babel(gulp).js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ gulp.task('inject:tsconfig', () => {
gulp.task('inject:css', () => {
return gulp.src(paths.client.mainView)
.pipe(plugins.inject(
gulp.src(`/${clientPath}/{app,components}/**/*.css`, {read: false})
gulp.src(paths.client.styles, {read: false})
.pipe(plugins.sort()),
{
starttag: '<!-- injector:css -->',
Expand Down Expand Up @@ -294,7 +294,7 @@ gulp.task('tsd:test', cb => {
});<% } %>

gulp.task('styles', () => {
return gulp.src(paths.client.mainStyle)
return gulp.src(paths.client.styles)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want this change. The 'styles' task should only used if you pick a CSS transpiler

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you propose an alternative fix to the problem I reported?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<%_ if(!filters.css) { _%>
return gulp.src(paths.client.mainStyle)
<%_ } else { _%>
return gulp.src(paths.client.styles)<% } %>

.pipe(styles())
.pipe(gulp.dest('.tmp/app'));
});<% if(filters.ts) { %>
Expand Down