Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return 404 when no user is found #711

Closed
dotch opened this issue Nov 25, 2014 · 3 comments
Closed

return 404 when no user is found #711

dotch opened this issue Nov 25, 2014 · 3 comments

Comments

@dotch
Copy link
Contributor

dotch commented Nov 25, 2014

currently a 401 is returned when no user was found.
see https://github.com/DaftMonk/generator-angular-fullstack/blob/master/app/templates/server/api/user(auth)/user.controller.js#L45
shouldn't this actually be a 404?
@anthonyettinger
Copy link

+1 seems like the logical thing to do here.

dotch added a commit to dotch/generator-angular-fullstack that referenced this issue Nov 27, 2014
@dotch
fix: return a 404 when no user is found fixes angular-fullstack#711
38c0d7c
@dotch dotch mentioned this issue Nov 27, 2014
Merged
@Awk34
Copy link
Member

Awk34 commented Dec 8, 2014

Pr was merged; this should be closed, ya?

@JaKXz JaKXz closed this as completed Dec 8, 2014
@JaKXz
Copy link
Collaborator

JaKXz commented Dec 8, 2014

Thanks @Awk34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dotch @JaKXz @Awk34 @anthonyettinger