Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ES6 breaks testing #1081

Closed
drochag opened this issue Jul 18, 2015 · 3 comments
Closed

Using ES6 breaks testing #1081

drochag opened this issue Jul 18, 2015 · 3 comments

Comments

@drochag
Copy link
Contributor

drochag commented Jul 18, 2015

I changed all the client code to ES6 with the babel option enabled on the canary branch.

After changing the following file:

'use strict';

angular.module('appName')
  .directive('footer', () => {
    return {
      templateUrl: 'components/footer/footer.html',
      restrict: 'E',
      link: (scope, element) => {
        element.addClass('footer');
      }
    };
  });

I'm getting this error when doing grunt test

INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket DuFkY1bEL9QB0nekjB20 with id 21853607
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  SyntaxError: Parse error
  at /Users/dan/Documents/projects/centro/client/components/footer/footer.directive.js:4

PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 0 of 0 ERROR (0.095 secs / 0 secs)

Warning: Task "karma:unit" failed. Use --force to continue.

Aborted due to warnings.
kingcody added a commit to kingcody/generator-angular-fullstack that referenced this issue Jul 20, 2015
@kingcody
Copy link
Member

@danmmx thank you very much for the bug report.

@drochag
Copy link
Contributor Author

drochag commented Jul 20, 2015

👍 thanks for guiding me to fix it, wasn't trivial for me that's why I didn't made a PR, but was an easy one

@kingcody
Copy link
Member

closed by #1084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants