Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): false positive conditional complexity in BoundAttribute > Interpolation #986

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Apr 14, 2022

Fixes #863

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #986 (800f98f) into master (870f466) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage   86.46%   86.53%   +0.07%     
==========================================
  Files         147      147              
  Lines        2778     2778              
  Branches      447      447              
==========================================
+ Hits         2402     2404       +2     
+ Misses        224      223       -1     
+ Partials      152      151       -1     
Flag Coverage Δ
unittest 86.53% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin-template/src/index.ts 65.95% <100.00%> (ø)
...lugin-template/src/rules/conditional-complexity.ts 100.00% <100.00%> (+5.12%) ⬆️
...mplate/tests/rules/conditional-complexity/cases.ts 100.00% <100.00%> (ø)

@JamesHenry JamesHenry merged commit c3f3120 into master Apr 14, 2022
@JamesHenry JamesHenry deleted the fix-conditional-complexity branch April 14, 2022 11:20
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 25, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint) | devDependencies | patch | [`13.2.0` -> `13.2.1`](https://renovatebot.com/diffs/npm/@angular-eslint%2fbuilder/13.2.0/13.2.1) |
| [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint) | devDependencies | patch | [`13.2.0` -> `13.2.1`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin/13.2.0/13.2.1) |
| [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint) | devDependencies | patch | [`13.2.0` -> `13.2.1`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin-template/13.2.0/13.2.1) |
| [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint) | devDependencies | patch | [`13.2.0` -> `13.2.1`](https://renovatebot.com/diffs/npm/@angular-eslint%2fschematics/13.2.0/13.2.1) |
| [@angular-eslint/template-parser](https://github.com/angular-eslint/angular-eslint) | devDependencies | patch | [`13.2.0` -> `13.2.1`](https://renovatebot.com/diffs/npm/@angular-eslint%2ftemplate-parser/13.2.0/13.2.1) |

---

### Release Notes

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/builder)</summary>

### [`v13.2.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#&#8203;1321-httpsgithubcomangular-eslintangular-eslintcomparev1320v1321-2022-04-14)

[Compare Source](angular-eslint/angular-eslint@v13.2.0...v13.2.1)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin)</summary>

### [`v13.2.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;1321-httpsgithubcomangular-eslintangular-eslintcomparev1320v1321-2022-04-14)

[Compare Source](angular-eslint/angular-eslint@v13.2.0...v13.2.1)

##### Bug Fixes

-   **eslint-plugin-template:** false positive conditional complexity in BoundAttribute > Interpolation ([#&#8203;986](angular-eslint/angular-eslint#986)) ([c3f3120](angular-eslint/angular-eslint@c3f3120))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin-template)</summary>

### [`v13.2.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#&#8203;1321-httpsgithubcomangular-eslintangular-eslintcomparev1320v1321-2022-04-14)

[Compare Source](angular-eslint/angular-eslint@v13.2.0...v13.2.1)

##### Bug Fixes

-   **eslint-plugin-template:** false positive conditional complexity in BoundAttribute > Interpolation ([#&#8203;986](angular-eslint/angular-eslint#986)) ([c3f3120](angular-eslint/angular-eslint@c3f3120))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/schematics)</summary>

### [`v13.2.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#&#8203;1321-httpsgithubcomangular-eslintangular-eslintcomparev1320v1321-2022-04-14)

[Compare Source](angular-eslint/angular-eslint@v13.2.0...v13.2.1)

**Note:** Version bump only for package [@&#8203;angular-eslint/schematics](https://github.com/angular-eslint/schematics)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/template-parser)</summary>

### [`v13.2.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#&#8203;1321-httpsgithubcomangular-eslintangular-eslintcomparev1320v1321-2022-04-14)

[Compare Source](angular-eslint/angular-eslint@v13.2.0...v13.2.1)

##### Bug Fixes

-   **template-parser:** suppress parse errors by default, add suppressParseErrors parserOption ([#&#8203;987](angular-eslint/angular-eslint#987)) ([417bee6](angular-eslint/angular-eslint@417bee6))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1307
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional Complexity
1 participant