feat: add support for observables to withDataService
#88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would close issue 85: suggestion/question: withDataService support for Observables
What was done
withDataService
was expanded to take Observable methodstype PromiseOrObservable<Entity> = Promise<Entity> | Observable<Entity>;
loadById(id: EntityId): PromiseOrObservable<Entity>;
loadById(id: EntityId): Promise<Flight> {...}
loadById(id: EntityId): Observable<Flight> {...}
withDataService
methods were adapted to take an observable (returns a subscription) as well as already taking promisestype PromiseOrSubscription<Entity> = Promise<Entity> | Subscription;
[K in Collection as `load${Capitalize<K>}Entities`]: () => PromiseOrSubscription<void>;
edit:
What was chosen not to be done, as per talk in the issue
rxMethod
is not used. The solution currently just manually subscribes. SupportingrxMethod
would widen the feature to need to take non-static values such as signals or observables.What is left to be done (before turning from Draft PR to regular PR)
withDataService
as is with promises, so I should probably make those first and get those in as a PR before moving onto this one. Thoughts?withDataService
#89DestroyRef
? Otherwise basictake(1)
orfirst
or something?