Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong conversion of list initializacion #68

Closed
angelolloqui opened this issue Mar 17, 2018 · 2 comments
Closed

Wrong conversion of list initializacion #68

angelolloqui opened this issue Mar 17, 2018 · 2 comments
Labels
bug

Comments

@angelolloqui
Copy link
Owner

This Swift:

var temporaryPlayers = [String]()

Currently translates to:

var temporaryPlayers = listOf(String)()

But should be:

var temporaryPlayers = listOf<String>()
@yohanhyunsungyi yohanhyunsungyi mentioned this issue Feb 18, 2019
Closed
@yohanhyunsungyi
Copy link

Hello,

I have fixed this bug and created a pull request.
Please review it.
#95

Thank you

angelolloqui added a commit that referenced this issue Feb 19, 2019
@angelolloqui
#68 Fixed list/map initialization
ecbf2d9
@angelolloqui
Copy link
Owner Author

Fixed with #96

angelolloqui added a commit that referenced this issue Feb 19, 2019
@angelolloqui
Merge pull request #96 from angelolloqui/feature/68-list-initialization
2b350cb 
#68 Fixed list/map initialization
TamirTwina added a commit to TamirTwina/SwiftKotlin that referenced this issue Aug 10, 2019
@TamirTwina
Merge remote-tracking branch 'upstream/develop' into develop
c36a3ea 
* upstream/develop: (41 commits)
  Version update
  Minor changes
  Added other members to enums
  Added other members to enum body
  Added extra tests for missing properties and functions
  Moved code into utils and added extra inheritance tokens
  Changed enum code to allow simple value types, and a rawValue constructor
  angelolloqui#68 Fixed list/map initialization
  Updated contributions
  angelolloqui#91 Fixed force cast conversion
  PR changes
  added  Assets/Tests/KotlinTokenizer/overrideargs.swift
  added funtion and code to remove default arguments from override function in class. With tests.
  add colors to token for dark mode cases
  Updated travis file and cleanup
  Updated readme file
  Removed autogenerated project file
  Removed local references
  Version update
  Updated swift transform to v0.18.10
  ...

# Conflicts:
#	Sources/SwiftKotlinApp/ViewController.swift
#	Sources/SwiftKotlinCommandLine/main.swift
#	Sources/SwiftKotlinFramework/KotlinTokenizer.swift
#	SwiftKotlin.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angelolloqui @yohanhyunsungyi