Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated viewer widget and added AB test widget #6

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

JLrumberger
Copy link
Collaborator

@JLrumberger JLrumberger commented Mar 21, 2024

What is the purpose of this PR?

  1. Add a viewer for the AB test between PIXIE and nimbus+pixie.
  2. Improve the regular viewer widget

How did you implement your changes

  1. Added a viewer widget comparable to the one in the video. In addition to the features in the video I added a third option for the cell type "None of the above".
  2. I also added a notebook with a mock cell table, that can be used to assess the viewer widget.
  3. Save and next button saves the annotations to $output_dir/annotations.csv and jumps to the next cell. If a user wants to stop and continue an annotation run, the input cell_df should be the annotations.csv for the continuation.
  4. Added instance segmentation overlay (comparable to the feature in the video) to the regular viewer widget.
cell_analysis.mp4

Remaining issues
None? Noah, do you want to have additional features?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JLrumberger JLrumberger requested a review from ngreenwald March 22, 2024 14:10
@JLrumberger JLrumberger changed the title Added cell segments to viewer_widget) Updated viewer widget and added AB test widget Mar 22, 2024
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we'll know if any features are missing once we try it out, for now this looks like a great MVP

@JLrumberger JLrumberger merged commit 178dccd into main Mar 28, 2024
11 of 12 checks passed
@JLrumberger JLrumberger deleted the update_viewer branch March 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants