Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to the RiverFlowDynamics notebook #2

Conversation

mcflugen
Copy link

Description

@angelmons, this pull request makes some changes to your RiverFlowDynamics notebook. The changes fall into the following categories:

  • Fix typos
  • Remov header cells to match other notebooks
  • Follow the latest Landlab best practices (e.g. esri_ascii.load rather than read_esri_ascii)
  • Clean up some of the loops to, I hope, make them more clear

Checklist - did you ...

  • Add a news fragment file entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?
  • All tests have passed?
  • Formatted code with black?
  • Removed lint reported by flake8?
  • Sucessful documentation built? (if documentation added or modified)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11429622734

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 73.234%

Files with Coverage Reduction New Missed Lines %
.nox/test-3-12/lib/python3.12/site-packages/landlab/components/lateral_erosion/node_finder.py 1 70.54%
.nox/test-3-10/lib/python3.10/site-packages/landlab/components/lateral_erosion/node_finder.py 3 71.43%
Totals Coverage Status
Change from base Build 11406556441: 0.004%
Covered Lines: 54928
Relevant Lines: 75003

💛 - Coveralls

@angelmons angelmons merged commit c617ac9 into angelmons:riverFlowDynamics_dev Oct 21, 2024
43 of 44 checks passed
@mcflugen mcflugen deleted the mcflugen/river-flow-dynamics-notebook branch October 21, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants