Modifications to RiverFlowDynamics

[mcflugen]

Description

@angelmons, I've been going through landlab#1979 (your RiverFlowDynamics component) and it looks great! Thank you!

I began to make suggestions for some rather minor changes but figured it might be easier for me to just go ahead and make them myself. As such, I thought I would try something a little different than we normally do.

If you're ok with it, my plan is to use this pull request as a base for some of these changes for you to review. I'll break this PR into several smaller ones to make them easier for you to review.

What do you think?

Checklist - did you ...

• Add a news fragment file entry if necessary?
• Add / update tests if necessary?
• Add new / update outdated documentation?
• All tests have passed?
• Formatted code with black?
• Removed lint reported by flake8?
• Sucessful documentation built? (if documentation added or modified)

[angelmons]

Description

@angelmons, I've been going through landlab#1979 (your RiverFlowDynamics component) and it looks great! Thank you!

I began to make suggestions for some rather minor changes but figured it might be easier for me to just go ahead and make them myself. As such, I thought I would try something a little different than we normally do.

If you're ok with it, my plan is to use this pull request as a base for some of these changes for you to review. I'll break this PR into several smaller ones to make them easier for you to review.

What do you think?

Checklist - did you ...

• Add a news fragment file entry if necessary?
• Add / update tests if necessary?
• Add new / update outdated documentation?
• All tests have passed?
• Formatted code with black?
• Removed lint reported by flake8?
• Sucessful documentation built? (if documentation added or modified)

Hi @mcflugen, Thank you so much!
Yes, please feel free to edit anything you see fit and proceed with your plan. I greatly appreciate your help and support.

[coveralls]

Pull Request Test Coverage Report for Build 11429531918

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 17 unchanged lines in 6 files lost coverage.
• Overall coverage decreased (-0.02%) to 73.214%

---

Files with Coverage Reduction	New Missed Lines	%
.nox/test-3-10/lib/python3.10/site-packages/landlab/components/lateral_erosion/node_finder.py	1	72.32%
.nox/test-3-12/lib/python3.12/site-packages/landlab/components/lateral_erosion/node_finder.py	1	67.86%
.nox/test-3-11/lib/python3.11/site-packages/landlab/components/lateral_erosion/node_finder.py	3	78.57%
.nox/test-3-11/lib/python3.11/site-packages/landlab/components/river_flow_dynamics/river_flow_dynamics.py	4	99.21%
.nox/test-3-12/lib/python3.12/site-packages/landlab/components/river_flow_dynamics/river_flow_dynamics.py	4	99.21%
.nox/test-3-10/lib/python3.10/site-packages/landlab/components/river_flow_dynamics/river_flow_dynamics.py	4	99.21%

Totals
Change from base Build 11406556441:	-0.02%
Covered Lines:	54770
Relevant Lines:	74808

---

💛 - Coveralls

[mcflugen]

Hi @mcflugen, Thank you so much! Yes, please feel free to edit anything you see fit and proceed with your plan. I greatly appreciate your help and support.

@angelmons Sounds good. Thanks! You weren't supposed to merge this pull request yet, though! 😄 I guess if it looked ok to you, then it's all good. I'll likely open up another one.

[angelmons]

Hi @mcflugen , hahaha, I am sorry. I was trying to solve the problem with the changelog entry.

I will wait this time. Please let me know when it is ready to review.

Thanks again.

[angelmons]

Hi @mcflugen, I was wondering what are the usual steps at this point regarding landlab#1979 (RiverFlowDynamics component)? I am a little bit lost and would like to be sure I am doing the right thing. Thanks for your help and support. Angel From: Eric Hutton ***@***.***> Sent: Sunday, October 20, 2024 10:50 PM To: angelmons/landlab ***@***.***> Cc: Monsalve Sepulveda, Angel ***@***.***) ***@***.***>; Mention ***@***.***> Subject: Re: [angelmons/landlab] Modifications to RiverFlowDynamics (PR #1) Hi @mcflugen, Thank you so much! Yes, please feel free to edit anything you see fit and proceed with your plan. I greatly appreciate your help and support. @angelmons Sounds good. Thanks! You weren't supposed to merge this pull request yet, Hi @mcflugen<https://urldefense.com/v3/__https:/github.com/mcflugen__;!!JYXjzlvb!neoOllE6PuvSG9V_KZ_gKtrP577HBKpCSh36H5mDjzGPxHxwbmrAmovarQzHvNt1bMgbm8o57rTMFkfONiA_bMHF$>, Thank you so much! Yes, please feel free to edit anything you see fit and proceed with your plan. I greatly appreciate your help and support. @angelmons<https://urldefense.com/v3/__https:/github.com/angelmons__;!!JYXjzlvb!neoOllE6PuvSG9V_KZ_gKtrP577HBKpCSh36H5mDjzGPxHxwbmrAmovarQzHvNt1bMgbm8o57rTMFkfONpl7rUf-$> Sounds good. Thanks! You weren't supposed to merge this pull request yet, though! 😄 I guess if it looked ok to you, then it's all good. I'll likely open up another one. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/angelmons/landlab/pull/1*issuecomment-2425392803__;Iw!!JYXjzlvb!neoOllE6PuvSG9V_KZ_gKtrP577HBKpCSh36H5mDjzGPxHxwbmrAmovarQzHvNt1bMgbm8o57rTMFkfONim13NJn$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AXC2BMWZPGURULAVQWUILBDZ4RMUJAVCNFSM6AAAAABQI3LMT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGM4TEOBQGM__;!!JYXjzlvb!neoOllE6PuvSG9V_KZ_gKtrP577HBKpCSh36H5mDjzGPxHxwbmrAmovarQzHvNt1bMgbm8o57rTMFkfONgRMdWGd$>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[mcflugen]

@angelmons I'm still going through it but am swamped at the moment so it's taking longer than usual.