style(*): add TODO comments when disabling eslint warnings

// TODO: fix this for proper typing and intellisense
aneurysmjs · Aug 25, 2020 · 860f728 · 860f728
1 parent b53c8cb
commit 860f728
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/src/app/components/core/UserMenu/UserMenu.tsx b/src/app/components/core/UserMenu/UserMenu.tsx
@@ -32,7 +32,8 @@ const UserMenu: FunctionComponent<PropsType> = ({ modules }: PropsType) => {
   return (
     <div className="user-menu">
       {Sidebar ? (
-        // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+        // TODO: fix typing for future releases
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore
         <Sidebar title="Cart" side="right" isOpen={open} onClose={handleOpen}>
           <p className="lead">You have nothing, let&apos;s shop!</p>

diff --git a/src/app/store/config/alienStore/manager.ts b/src/app/store/config/alienStore/manager.ts
@@ -1,8 +1,8 @@
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
 import { AnyAction, combineReducers, Dispatch, Reducer } from 'redux';
 
 import { FullStoreShape, ReducerMapper } from './types/alienStore';
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 export interface AlienManager<R = {}> {
   getReducerMap: () => ReducerMapper<FullStoreShape<R>>;
   injectReducers: (key: string, reducer: Reducer) => Reducer | void;
@@ -18,11 +18,14 @@ export default function manager<State>(initialReducers?: State): AlienManager<St
 
   type ReducerMap = ReducerMapper<StoreShape>;
 
+  // eslint-disable-next-line @typescript-eslint/ban-types
   const fallback = (): {} => ({});
 
   let dispatch: AlienDispatch = null;
 
   const reducerMap: ReducerMap = initialReducers ? { ...initialReducers } : {};
+  // TODO: fix this for proper typing and intellisense
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore "combineReducers" doesn't have that overload match
   let combinedReducer = initialReducers ? combineReducers(reducerMap) : fallback;
 
@@ -42,6 +45,8 @@ export default function manager<State>(initialReducers?: State): AlienManager<St
     }
 
     reducerMap[key] = reducer;
+    // TODO: fix this for proper typing and intellisense
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore "combineReducers" doesn't have that overload match
     combinedReducer = combineReducers(reducerMap);
     if (dispatch) {
@@ -57,6 +62,8 @@ export default function manager<State>(initialReducers?: State): AlienManager<St
     delete reducerMap[key];
 
     keysToRemove.push(key);
+    // TODO: fix this for proper typing and intellisense
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore "combineReducers" doesn't have that overload match
     combinedReducer = combineReducers(reducerMap);
   }

diff --git a/src/app/store/config/alienStore/useAlien.tsx b/src/app/store/config/alienStore/useAlien.tsx
@@ -5,6 +5,8 @@ import { isEmpty, isNil, anyPass } from 'ramda';
 
 import { AlienStore } from './alien';
 
+// TODO: fix this for proper typing and intellisense
+// eslint-disable-next-line @typescript-eslint/ban-types
 export interface ReduxModule<S = {}> {
   id: string;
   reducers: {
@@ -21,6 +23,8 @@ export interface ReduxModule<S = {}> {
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type AlienResult<S = any> = Omit<ReduxModule<S>, 'reducers'>;
 
+// TODO: fix this for proper typing and intellisense
+// eslint-disable-next-line @typescript-eslint/ban-types
 export interface AlienModule<T = {}> {
   initialActions?: Array<string>;
 }

diff --git a/src/app/store/config/alienStore/withAlien.tsx b/src/app/store/config/alienStore/withAlien.tsx
@@ -5,7 +5,8 @@ import useAlien, { AlienResult, ReduxModule } from './useAlien';
 interface WithAlienProps {
   modules: Array<AlienResult>;
 }
-
+// TODO: fix this for proper typing and intellisense
+// eslint-disable-next-line @typescript-eslint/ban-types
 function WithAlien<P extends object>(
   Component: ComponentType<P>,
   reduxModules: Array<() => Promise<ReduxModule<P>>>,