Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Items and Custom to FieldSchema #332

Merged

Conversation

bossinc
Copy link
Contributor

@bossinc bossinc commented Jan 7, 2021

Description

Please describe what does this Pull Request fix or add?.
Adding Items and Custom to FieldSchema so they can be used to determine the data type of a Jira field.

Information that is useful here:

  • The What: Adding Items and Custom to FieldSchema
  • The Why: For example, the Type can be array and the Items can be string or some other type. It is useful to have that information if the user wants to get more information about the data type
  • Type of change: New feature
  • Breaking change: No
  • Related to an issue: Does this fix or close an issue? Or is related in any kind?
  • Jira Version + Type: Cloud

Example:

Let us know how users can use or test this functionality.

// Example code

Checklist

@andygrunwald
Copy link
Owner

Hey @bossinc,
thanks a lot for this PR.
Do you have a link to the documentation for us where this is documented?

@bossinc
Copy link
Contributor Author

bossinc commented Jan 7, 2021

https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-issue-fields/#api-rest-api-2-field-get

Under Responses click Array<FieldDetails>. At the bottom of the popup box will be schema with a clickable type of JsonTypeBean. The documentation is here. I am not sure if there is a better way to find this. I feel like this was pretty obscure to find.

Copy link
Owner

@andygrunwald andygrunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bossinc!
Overall it is looking good. One copy/paste mistake and two smaller things.
Let me know what you think about this.

field.go Outdated Show resolved Hide resolved
field.go Outdated Show resolved Hide resolved
field.go Show resolved Hide resolved
@bossinc
Copy link
Contributor Author

bossinc commented Jan 8, 2021

@andygrunwald thank you for for finding the copy/paste mistake and you are right to add the other two fields. Thank you!

@andygrunwald andygrunwald merged commit 3754d5a into andygrunwald:master Jan 9, 2021
@andygrunwald
Copy link
Owner

Thanks @bossinc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants