Pythonise minpack2.dcsrch #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My motto is "if it works, it works". If we have the same functionalities and didn't slow down 500x, i don't have any issues with tbe style |
|
I'm not sure if it is important to your immediate use case but the LBFGSB uses another copy of this class in its own code which is also clarified in scipy#10456 . Hence I'd say a definite improvement since now we can investigate or refactor it as we please as a Python code regardless how complex it can get. |
andyfaff
force-pushed
the
minpack2
branch
2 times, most recently
from
db33ef4
to
566fa96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ilayn, I put some effort into Pythonising
minpack2.dcsrch. Is this the kind of conversion that's required? Or is it too much of a "we wrote Fortran in Python"?