Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments after a double-dash are always treated as relative paths if… #102

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Arguments after a double-dash are always treated as relative paths if… #102

merged 1 commit into from
Mar 18, 2020

Conversation

carlolars
Copy link
Contributor

… they look like relative paths.

Fixes converting relative paths to non-existing files after a double-dash. #96

I've searched the documentation for the git commands for -- and as far as I can see this fix should work fine. Maybe there are some advanced use-cases that might be found later, but it has worked for me for the last few weeks.

… they look like relative paths.

Fixes converting relative paths to non-existing files after a double-dash. #96
@andy-5
Copy link
Owner

andy-5 commented Mar 18, 2020

Thanks! I also quickly looked through the documentation and think that converting after -- is fine. The need for unsafe is unfortunate, but let's keep it for now to keep the code simple. There is no real problem with it here.

@andy-5 andy-5 merged commit 515d01c into andy-5:develop Mar 18, 2020
@carlolars carlolars deleted the 96_relative-path-after-double-dash branch March 18, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants