Ensure modules behavior is gated by enable option #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NixOS modules at `<jetpack-nixos>/modules/{flash-script.nix,devices.nix}`
should not do anything unless `hardware.nvidia-jetpack.enable` is
`true`.
jmbaur
force-pushed
the
module-conditionally-enable
branch
from
83e5001 to
fd55c4b
Compare
You're welcome! This one was for you |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The NixOS modules at
<jetpack-nixos>/modules/{flash-script.nix,devices.nix}should not do anything unlesshardware.nvidia-jetpack.enableistrue.Testing
Ensured behavior in these modules is still active on jetson devices (and no longer active on non-jetsons).