Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable link to OE4T/meta-tegra instead of master #187

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

IlyaNiklyaev
Copy link
Contributor

Recent update in repo https://github.com/OE4T/meta-tegra (this one OE4T/meta-tegra@b86c2ae) in fact breaks jetpack-nixos build:

hash mismatch in fixed-output derivation '/nix/store/n59rw7dri9dacvrav379m3i621qql6nf-0003-Update-conversion-defaults-to-match-NVIDIA-sources.patch.drv':
      >          specified: sha256-vGilgHWinrKjX+ikHo0J20PL713+w+lv46dBgfdvsZM=
      >             got:    sha256-6xCEjf432FLksCCk8+EpAbQU3PeGICOQ+6Q2OusUNa4=

I think we should refer all external repos by stable links to the certain commits instead of branches.

Description of changes
Testing

Recent update in repo https://github.com/OE4T/meta-tegra (this one OE4T/meta-tegra@b86c2ae) in fact breaks `jetpack-nixos` build:
```
hash mismatch in fixed-output derivation '/nix/store/n59rw7dri9dacvrav379m3i621qql6nf-0003-Update-conversion-defaults-to-match-NVIDIA-sources.patch.drv':
      >          specified: sha256-vGilgHWinrKjX+ikHo0J20PL713+w+lv46dBgfdvsZM=
      >             got:    sha256-6xCEjf432FLksCCk8+EpAbQU3PeGICOQ+6Q2OusUNa4=
```

I think we should refer all external repos by stable links to the certain commits instead of branches.
@danielfullmer danielfullmer merged commit 6ae4ce1 into anduril:master Feb 7, 2024
1 check passed
@danielfullmer
Copy link
Collaborator

Thanks! You're right, all references to patches on github should refer explicitly to a commit and not to a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants