-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial OCI container support #172
Conversation
Could you also add an automated test for this functionality to our internal nightly tests? |
Already added! |
62c85ed
to
4bf8bea
Compare
3bbb090
to
8eb3d79
Compare
8eb3d79
to
afa48f3
Compare
4dd4200
to
c9504eb
Compare
These changes add OCI container support for Tegra devices on NixOS. This is accomplished using NVIDIA's newer nvidia-ctk tooling, which uses the CDI spec. Docker does not yet support this spec in any released version, but will have experimental support for it in their next release. Podman has supported this spec for a few years. See changes to README.md for more notes.
c9504eb
to
74d4bd4
Compare
Notice (outdated nvidia-container-toolkit): It has been quite some time since I last upgraded the version of the nvidia-container-toolkit. If you have the time, please look at how to update the nvidia-container-toolkit to the latest version? The current version of nvidia-container-toolkit is outdated. thanks |
@GTrunSec I'll draft up a PR for nixpkgs targeting Nvidia container toolkit v1.15.0. This PR is highly focused on tegra support, but it would be great to use the same stuff on x86_64 too. |
@jmbaur, sweet, thanks for your efforts. Feel free to ping me to review that code once you are ready. |
How do NixOS/nixpkgs#284507 and NixOS/nixpkgs#291828 relate to this? |
The goal is to have all CDI support come from nixpkgs and eventually remove the tegra specific CDI support from this project. We need to verify that the newly added CDI support in nixpkgs works on tegra devices. |
Description of changes
These changes add OCI container support for Tegra devices on NixOS. This is accomplished using NVIDIA's newer
nvidia-ctk
tooling, which uses the CDI spec. Docker does not yet support this spec in any released version, but will have experimental support for it in their next release. Podman has supported this spec for a few years. See changes to README.md for more notes.Closes #5
Closes #117
Testing
Tested running a simple cuda program on an orin-agx-devkit0 with the nvcr.io/nvidia/l4t-base:35.3.1 image.