Skip to content

Commit

Permalink
flash-tools: add back missing lz4c program
Browse files Browse the repository at this point in the history
Since lz4/lz4@65998fe,
the lz4c symlink no longer exists, but is wanted by `flash.sh`. The
`lz4` program adds a set of legacy cmdline flags when `argv[0]` is
`lz4c` (see https://github.com/lz4/lz4/blob/6cf42afbea04c9ea6a704523aead273715001330/programs/lz4cli.c#L444),
however NVIDIA doesn't use any of these legacy flags in `flash.sh`, they
only require the `lz4c` program to be in PATH.
  • Loading branch information
jmbaur committed Dec 12, 2024
1 parent abfe7f4 commit 20328be
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions pkgs/flash-tools/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
, openssl
, bspSrc
, l4tVersion
,
, symlinkJoin
}:

let
Expand Down Expand Up @@ -121,13 +121,22 @@ let
python3
util-linux
dosfstools
lz4
bc
openssl

# Needed by bootloader/tegraflash_impl_t234.py
gcc
dtc

# flash.sh wants lz4c, which used to be a symlink to lz4, but does not
# exist in more recent nixpkgs.
(symlinkJoin {
inherit (lz4) name;
paths = [ (lib.getBin lz4) ];
postBuild = ''
ln -sf $out/bin/lz4{,c}
'';
})
];
};

Expand Down

0 comments on commit 20328be

Please sign in to comment.