RLP: adapting to changes in Solidity version 0.5.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
chriseth
reviewed
Jul 18, 2018
| @@ -208,10 +210,10 @@ library RLP { | |||
| /// RLPItem is a list. | |||
| /// @param self The RLPItem. | |||
| /// @return The decoded string. | |||
| function toAscii(RLPItem memory self) internal constant returns (string memory str) { | |||
| function toAscii(RLPItem memory self) internal returns (string memory str) { | |||
There was a problem hiding this comment.
Ah because _copyToBytes still uses jumps.
chriseth
approved these changes
Jul 18, 2018
|
Shouldn't this also update the assembly? |
|
I vote for updating the assembly and promoting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the RLP.sol to the changes needed when you compile this file with a solidity compiler version 0.5.0+, which is not yet released, but you can test it already with current compiler that has experimental v0.5.0 features enabled.
This PR basically contains the changes we did in order to get our test suite pass.